Fire callbacks when targets are added or removed #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes [#336][] --- Implements the `TargetObserver` to monitor when elements declaring `[data-${identifier}-target]` are added or removed from a `Context` _after_ being connected and _before_ being disconnected. In support of iterating through target tokens, export the `TokenListObserver` module's `parseTokenString` function. [#336]: #336
Member
|
Would be happy to see this move forward 👍 |
domchristie
added a commit
to domchristie/webrtc-hotwire-rails
that referenced
this pull request
Jun 26, 2021
Replace event system with TargetObserver as proposed in hotwired/stimulus#409 and teardown clients when the remote video is removed
domchristie
added a commit
to domchristie/webrtc-hotwire-rails
that referenced
this pull request
Jun 26, 2021
Replace event system with TargetObserver as proposed in hotwired/stimulus#409 and teardown clients when the remote video is removed
|
@dhh, I'm keen to start using this feature but it doesn't look like there has been a release since December 2020. Will a new tag be released soon for 2.1? |
Member
|
@trsteel88 There is a new release planned. In the meantime you can use the latest dev-build in order to make use of this feature today. Swap your Stimulus dependency in your "stimulus": "https://github.com/hotwired/dev-builds/archive/stimulus/353890e.tar.gz" |
|
Thanks @marcoroth. Do you have a set release cycle documented? p.s absolutely loving stimulus and turbo links! Great work guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I take no credit for this, Sean Doyle did all the hard work in #367. If Sean no longer wants to commit his time to maintaining this PR, I understand. But it would be a terrible shame for this work to be abandoned at the 11th hour, as this is a piece of functionality I think a lot of Stimulus developers have on their wishlist.
If all parties are happy for the work he did to still go forward, I'm happy to take this over the line.