fix: prevent call stack overflow when used with prettier-plugin-tailwindcss#255
Open
shun-shobon wants to merge 1 commit intohosseinmd:masterfrom
Open
fix: prevent call stack overflow when used with prettier-plugin-tailwindcss#255shun-shobon wants to merge 1 commit intohosseinmd:masterfrom
shun-shobon wants to merge 1 commit intohosseinmd:masterfrom
Conversation
Collaborator
|
LGTM, please update the README adding a note about this behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #254
The root cause was that
prettier-plugin-jsdocdelegates parse/preprocess to “another plugin that provides the same parser” by scanning options.plugins, but it could accidentally pick a plugin that appears afterprettier-plugin-jsdoc(e.g. tailwindcss). Since tailwindcss wraps other parsers, delegating back to it from inside jsdoc creates a circular call chain like tailwind.preprocess -> jsdoc.preprocess -> tailwind.preprocess -> ..., eventually overflowing the call stack.To prevent this,
findPluginByParser()now only considers plugins that appear beforeprettier-plugin-jsdocinoptions.plugins, avoiding delegation back into wrapper plugins while preserving compatibility with earlier parser plugins.