Skip to content

Conversation

@ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Oct 24, 2025

closes #4477

The middleware validation accepts = to use a Base64 string like AWS request id.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.30%. Comparing base (4b796cf) to head (8d99dcb).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4478      +/-   ##
==========================================
- Coverage   91.32%   91.30%   -0.02%     
==========================================
  Files         173      173              
  Lines       11084    11190     +106     
  Branches     3201     3228      +27     
==========================================
+ Hits        10122    10217      +95     
- Misses        961      972      +11     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@ryuapp Thank you for the quick fix!

@yusukebe yusukebe merged commit 5216117 into honojs:main Oct 24, 2025
20 checks passed
@ryuapp ryuapp deleted the request-id/accept-equal branch October 24, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request ID - Can't use aws cloudfront request id

2 participants