feat(helper/route): enable to get route path at specific index #4423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yusukebe What do you think about this? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4423 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 171 171
Lines 10913 10915 +2
Branches 3144 3146 +2
=======================================
+ Hits 9959 9961 +2
Misses 953 953
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yusukebe
reviewed
Sep 24, 2025
| */ | ||
| export const routePath = (c: Context): string => matchedRoutes(c)[c.req.routeIndex].path | ||
| export const routePath = (c: Context, index?: number): string => | ||
| matchedRoutes(c).at(index ?? c.req.routeIndex)?.path ?? '' |
There was a problem hiding this comment.
It isn't easy to define the behavior if it cannot find the route. I think both '' and undefined are okay. In this case, '' is better because this way does not break that routePath returns value is string (not string | undefined). So this is good.
|
Hi @usualoma This is a good idea! Looks good. The change is only adding the one option, so we can include this in the next patch release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4196
Currently, only routes associated with handlers can be retrieved. This PR enables passing an optional
indexparameter (which has the same meaning asArray.prototype.at(index)), allowingroutePath(c, -1)to retrieve the route that matched at the end.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code