-
-
Notifications
You must be signed in to change notification settings - Fork 844
ci: add HTTP speed check #4220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ci: add HTTP speed check #4220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add performance benchmarking tool inspired by bun-http-framework-benchmark: - Test ping/query/body endpoints - Compare Git revisions - Output results in table format 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4220 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 168 168
Lines 10707 10707
Branches 3099 3086 -13
=======================================
Hits 9781 9781
Misses 925 925
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Rename directory from perf-measures/http-benchmark to perf-measures/speed-check for better naming consistency. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Add HTTP performance benchmarking to the consolidated performance measurement system with --ci mode support. - Move benchmark.ts to scripts/ directory for consistency - Add --ci flag for CI-optimized execution (silent mode, JSON output) - Integrate speed-check results into octocov configuration - Install bombardier automatically in CI - Preserve detailed comparison mode for local development 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Update GitHub Actions job names to reflect the addition of HTTP speed checking alongside type checking and bundle size checking. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Fix 404 error by updating to bombardier v2.0.1 and downloading the binary directly instead of using a tar.gz archive that no longer exists. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Skip buildVersion in CI mode and use existing dist folder directly - Reorder metrics display: Bundle size -> Speed check -> Compiler diagnostics - Eliminate unnecessary build steps that caused CI failures 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix cp command path from `/dist` to `${HONO_ROOT}/dist`
- Change log function parameter type from any[] to unknown[]
- Run format:fix and lint:fix to resolve style issues
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
Replace process.cwd() with import.meta.dirname to ensure paths are resolved relative to the script file location, not the execution directory. This fixes dist folder path issues in CI. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This comment has been minimized.
This comment has been minimized.
Bundle size check
Compiler Diagnostics (tsc)
Compiler Diagnostics (typescript-go)
HTTP speed check
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Performance Measurement Consolidation
HTTP Speed Check Integration
benchmark.tstoscripts/directory for consistency with other perf-measures--ciflag for CI-optimized execution (silent mode, JSON output for octocov)Technical Implementation
Test plan
🤖 Generated with Claude Code