-
-
Notifications
You must be signed in to change notification settings - Fork 846
CI: add type benchmark with typescript-go preview #4161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4161 +/- ##
========================================
Coverage 91.31% 91.31%
========================================
Files 168 168
Lines 10788 10788
Branches 3183 3036 -147
========================================
Hits 9851 9851
Misses 936 936
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It seems an error is occurring when type checking external libraries. note: This is not happening in Details
|
|
I think we can add |
25d8559 to
6c0191c
Compare
|
@yusukebe |
6c0191c to
fad8227
Compare
|
Is this ready for review? |
|
@yusukebe Yes! |
9319536 to
9a05e7c
Compare
|
As a concern, there is a possibility that the comments from the results executed with tsc and the comments from the results executed with typescript-go may conflict and not be updated correctly. => should be solved in f01be98 |
|
When Octocov updates items such as comments, it internally uses the 'repository' value set in its configuration. Therefore, for the I preferred adding more configuration files over dynamically generating YAML on CI. What are your thoughts? |
|
repository: ${GITHUB_REPOSITORY}/perf-measures I haven't changed the repository name in existing tsc benchmark config |
I also prefer using configuration files over generating YAML on CI. |
yusukebe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Looks good! Let's go with this. Thanks! |
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code