Skip to content

Conversation

@Hill-98
Copy link
Contributor

@Hill-98 Hill-98 commented May 2, 2025

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@codecov
Copy link

codecov bot commented May 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (c277c75) to head (c20c6aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4123      +/-   ##
==========================================
- Coverage   91.34%   91.31%   -0.04%     
==========================================
  Files         168      168              
  Lines       10700    10784      +84     
  Branches     3181     3045     -136     
==========================================
+ Hits         9774     9847      +73     
- Misses        925      936      +11     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented May 3, 2025

@Hill-98

It's a bug! Thanks. I'll merge this now.

@yusukebe yusukebe merged commit ebc7e4b into honojs:main May 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants