Skip to content

Conversation

@yusukebe
Copy link
Member

Updated wrangler in devDependencies to 4.12.0 from 3.58.0 for the workerd runtime test.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@github-actions
Copy link

Bundle size check

main (5ca6c6e) #4096 (7adab06) +/-
Bundle Size (B) 18,904B 18,904B 0B
Bundle Size (KB) 18.46K 18.46K 0K

Compiler Diagnostics

main (5ca6c6e) #4096 (7adab06) +/-
Files 261 261 0
Lines 116,434 116,434 0
Identifiers 114,428 114,428 0
Symbols 303,852 303,852 0
Types 214,828 214,828 0
Instantiations 3,091,594 3,091,594 0
Memory used 454,677K 444,565K -10,112K
I/O read 0.03s 0.02s -0.01s
I/O write 0s 0s 0s
Parse time 0.81s 0.68s -0.13s
Bind time 0.35s 0.28s -0.07s
Check time 5.66s 5.63s -0.03s
Emit time 0s 0s 0s
Total time 6.82s 6.59s -0.23s

Reported by octocov

@codecov
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (5ca6c6e) to head (541a8cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4096      +/-   ##
==========================================
+ Coverage   91.29%   91.33%   +0.03%     
==========================================
  Files         168      168              
  Lines       10766    10682      -84     
  Branches     3088     3143      +55     
==========================================
- Hits         9829     9756      -73     
+ Misses        936      925      -11     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

})
ws.addEventListener('close', async () => {
closeHandler()
resolve(undefined)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should resolve when in the close event. Otherwise, the test will fail.

@yusukebe yusukebe changed the title test(workerd): bump wrangler to 4.12.0 chore(workerd): bump wrangler to 4.12.0 Apr 20, 2025
@yusukebe yusukebe changed the title chore(workerd): bump wrangler to 4.12.0 chore(deps): bump wrangler to 4.12.0 Apr 20, 2025
Copy link
Contributor

@ryuapp ryuapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@yusukebe yusukebe merged commit b008006 into main Apr 20, 2025
16 checks passed
@yusukebe yusukebe deleted the test/bump-wrangler branch April 20, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants