Skip to content

Conversation

@yusukebe
Copy link
Member

After updating to the latest Deno 2.2.9, the CI stopped in the runtime test for Deno:

https://github.com/honojs/hono/actions/runs/14440296335/job/40488744441

Previously, the test was flaky because the delay before aborting the request (10ms) was too short. This change ensures we wait until the stream has actually started before sending the abort signal.

This PR should fix the CI problems.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@github-actions
Copy link

Bundle size check

main (fb84c0b) #4068 (dfb8859) +/-
Bundle Size (B) 18,976B 18,976B 0B
Bundle Size (KB) 18.53K 18.53K 0K

Compiler Diagnostics

main (fb84c0b) #4068 (dfb8859) +/-
Files 261 261 0
Lines 116,443 116,443 0
Identifiers 114,436 114,436 0
Symbols 303,844 303,844 0
Types 214,831 214,831 0
Instantiations 3,091,594 3,091,594 0
Memory used 449,833K 446,173K -3,660K
I/O read 0.02s 0.02s 0s
I/O write 0s 0s 0s
Parse time 0.67s 0.67s 0s
Bind time 0.29s 0.29s 0s
Check time 5.66s 5.7s 0.04s
Emit time 0s 0s 0s
Total time 6.62s 6.66s 0.04s

Reported by octocov

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (02377ef) to head (d224c8c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4068      +/-   ##
==========================================
- Coverage   91.32%   91.29%   -0.04%     
==========================================
  Files         168      168              
  Lines       10689    10774      +85     
  Branches     3053     3064      +11     
==========================================
+ Hits         9762     9836      +74     
- Misses        926      937      +11     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe
Copy link
Member Author

Hey @usualoma !

Can you review this?

@usualoma
Copy link
Member

Hi @yusukebe

Thanks for the update.
It's good!

@yusukebe
Copy link
Member Author

@usualoma Thanks! Merging.

@yusukebe yusukebe merged commit 5acefd6 into main Apr 14, 2025
16 checks passed
@yusukebe yusukebe deleted the test/deno-wait-stream-start-for-abort branch April 14, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants