Skip to content

Conversation

@EdamAme-x
Copy link
Contributor

@EdamAme-x EdamAme-x commented Feb 19, 2025

I noticed that there is no need to declare using let.
Also, one comment was incorrect and has been corrected.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@EdamAme-x EdamAme-x changed the title refactor(pattern-router): reduce bundle size and remove outdated comm… refactor(pattern-router): reduce bundle size and remove outdated comments Feb 19, 2025
@EdamAme-x EdamAme-x changed the title refactor(pattern-router): reduce bundle size and remove outdated comments refactor(pattern-router): reduce bundle size and fix comments Feb 19, 2025
@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (c9bd830) to head (d0b5508).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3936      +/-   ##
==========================================
- Coverage   91.32%   91.29%   -0.04%     
==========================================
  Files         168      168              
  Lines       10686    10772      +86     
  Branches     3061     3173     +112     
==========================================
+ Hits         9759     9834      +75     
- Misses        926      937      +11     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@EdamAme-x Thank you!

@yusukebe yusukebe merged commit a2ec848 into honojs:main Feb 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants