Add climate group

[daenny]

Proposed change

Adds a climate group component. Based initially on https://github.com/daenny/climate_group, but updated to be similar to the existing light/fan implementations.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: docs: added climate group docs home-assistant.io#23990

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[homeassistant]

Hello @daenny,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

• ae5b3c43fb3ed250a8b50490ec3edad764033590 - This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

   • If you only made a single commit you should be able to run

     git commit --amend --author="Author Name <[email protected]>"
     

     (substituting Author Name and [email protected] for your actual information) to set the authorship information.
   • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
     1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
     2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
   • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

[probot-home-assistant]

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (group) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[daenny]

Thanks for the review @boswelja , I adjusted the code accordingly!

[ignisf]

@daenny, thank you for contributing this, I am eagerly awaiting its merge. Maybe the pylint warning needs to be looked into as well?

[daenny]

Yes, that's a new one after making my branch upstream. I will look at it tomorrow

[KartoffelToby]

@daenny I wonder how the local calibration entities and also the valve_position entities can interact, or is it possible to query the values directly within the group via the attributes of the climate devices? since they are separate entities this is confusing. the climate entity still has the attributes local_temperature_calibration and valve_position, is it still possible to change them directly, or do you have to go through your own entities?

[KartoffelToby]

Many climate Intigrations have different Services to set a Offset/calibration think its time to bundle them under a global Services like service climate set offset

[daenny]

Many climate Intigrations have different Services to set a Offset/calibration think its time to bundle them under a global Services like service climate set offset

I agree that that would make sense, something like a SUPPORT_CALIBRATION flag, but I feel that is out of scope of this PR. It first has to be added to the generic climate and afterwards it shoudl also be added to this group integration

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[ignisf]

Just chiming in to mostly tell the stale bot off and that it would be awesome to have this for the heating season <3

[magicmellon]

Just chiming in to mostly tell the stale bot off and that it would be awesome to have this for the heating season <3

Totally agree - started using this addon today and it made hours of node-red making take an hour of refactoring. Would be awesome to see an official implimentation as it is one of the few things that isnt UI Configurable as a group.

[vordenken]

Would love to see some progress on this as well. Can't help but would love to test if anything needs it.

[edenhaus]

Can you please rebase and fix the merge conflicts?

After that, I can start reviewing your PR

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[r0bb10]

@daenny any news on the fixes? so it could be reviewed and maybe finally added in core.

[andrewthauer]

I found myself wanting this feature and stumped across this PR. It seems it's based on https://github.com/daenny/climate_group which suggests this PR may be abandoned.

[r0bb10]

I found myself wanting this feature and stumped across this PR. It seems it's based on https://github.com/daenny/climate_group which suggests this PR may be abandoned.

yeah i saw that too, this wont probably be addressed until someone expert enough finishes forks and pr again.

[jayme-github]

Can you please rebase and fix the merge conflicts?

After that, I can start reviewing your PR

Hey, I did a rebase with small adaptions, updated strings.json and did local testing at https://github.com/jayme-github/home-assistant-core/tree/feature/climate-group. As I can probably not re-use this PR, should I create a new one for you to review? I'm up to take care of follow ups to get this merged.

[r0bb10]

Can you please rebase and fix the merge conflicts?
After that, I can start reviewing your PR

Hey, I did a rebase with small adaptions, updated strings.json and did local testing at https://github.com/jayme-github/home-assistant-core/tree/feature/climate-group. As I can probably not re-use this PR, should I create a new one for you to review? I'm up to take care of follow ups to get this merged.

oh wow this is really a good news! keep it up!

[ignisf]

should I create a new one for you to review?

Could you please leave a reference to the new PR here so we can track it?

[jascdk]

any thoughts of if this is gonna be merged into HA?

[r0bb10]

should I create a new one for you to review? I'm up to take care of follow ups to get this merged.

@jayme-github any news?

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

[auanasgheps]

bump! :)

[albertomontesg]

Trying to revamp this work with a parallel PR which I would be happy to follow up and make sure it is being merged: #114290

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!