Add Abode entity available property#32923
Conversation
bdraco
left a comment
There was a problem hiding this comment.
Please see inline comments. Thank you!
|
CI Failure is unrelated |
bdraco
left a comment
There was a problem hiding this comment.
Approved, subject to upstream change being merged and a re-run of the CI
|
@shred86 mentioned more changes are coming. I'll come back for another review pass later. |
|
Finally figured out a fix to a small issue I was having. Just waiting for my PR in abodepy to be merged then I'll make a commit to this PR to bump the abodepy version and it should be good to go. |
afd3cf8 to
7de0a87
Compare
|
@shred86 Is this still waiting for upstream? I'm assuming its this one MisterWil/abodepy#67 |
|
I am. I sent @MisterWil a message on Discord but haven't heard from him yet. Once that upstream PR is merged, this should be good to go. |
|
PR was merged on abodepy. Just made a commit to bump the abodepy version. |
6292b2c to
c415cf3
Compare
|
|
||
| async def async_added_to_hass(self): | ||
| """Subscribe to Abode connection status updates.""" | ||
| self.hass.async_add_job( |
There was a problem hiding this comment.
hass.async_add_job is legacy for general use. Either use hass.async_create_task to schedule coroutines or hass.async_add_executor_job to schedule functions that need to run in the executor thread pool.
There was a problem hiding this comment.
I'll fix this in a new PR, thanks!
Proposed change
Adds the
availableproperty to Abode entities. This PR goes with some changes required to Abodepy which I have a pull request open for. Theavailableproperty is updated based on the status of the web socket connection to Abode's servers.Also adds the
PlatformNotReadyexception if the integration setup fails due to a connection issue. I can move this to a separate PR if desired but it's a one line change.This should not be merged until my Abodepy pull request is merged and I bump the Abodepy version.
The reason I'm making this PR now is to get feedback since the two PRs work together.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: