-
-
Notifications
You must be signed in to change notification settings - Fork 36.7k
Deprecate object_id and instead suggest to use default_entity_id to set the suggested entity_id in MQTT entity configurations #151775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…et the suggested entity_id in MQTT entity configurations
|
Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
emontnemery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jbouwh 👍
|
@koenk pinging you, as you might want to update Z2M |
| "issues": { | ||
| "deprecated_object_id": { | ||
| "title": "Deprecated option object_id used", | ||
| "description": "Entity {entity_id} uses the `object_id` option which deprecated. To fix the issue, replace the `object_id: {object_id}` option with `default_entity_id: {domain}.{object_id}` in your \"configuration.yaml\", and restart Home Assistant." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"is" missing -> "… which is deprecated. …"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…et the suggested entity_id in MQTT entity configurations (home-assistant#151775)
Proposed change
Deprecate
object_idand instead suggest to usedefault_entity_idto set the suggestedentity_idin MQTT entity configurations.Type of change
Additional information
default_entity_idto replaceobject_idfor mqtt entity platforms home-assistant.io#40749Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: