Add battery optimization permission to onboarding

[TimoPtr]

Summary

Add missing battery optimization to the onboarding flow. It was there before the PR is bringing this to the onboarding. The permission is going to be displayed on the Set home network screen.

Checklist

• New or updated tests have been added to cover the changes following the testing guidelines.
• The code follows the project's code style and best_practices.
• The changes have been thoroughly tested, and edge cases have been considered.
• Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

[jpelgrom]

Onboarding already continues in the background while the permission pop-up is shown, but I don't think that is an issue as we can continue without approval.

[jpelgrom]

Actually, I can't get the dialog to show when onboarding with a https url, probably because location sharing is the last step and continue means the activity transitions. Did you test that flow?

[TimoPtr]

Actually, I can't get the dialog to show when onboarding with a https url, probably because location sharing is the last step and continue means the activity transitions. Did you test that flow?

Nope I didn't test with HTTPS you're right... But then we have an issue until the WebView is part of the graph ....and not a standalone activity.

Or we need to show this dialog after the notification permission but that kinda sucks. Any other ideas?

[jpelgrom]

startActivityForResult and wait for it to return? (not tested)

[TimoPtr]

startActivityForResult and wait for it to return? (not tested)

Good call 👍🏻 It does work as intended, I tested on Android 9 and 6.

[jpelgrom]

Tested again and now it waits before continuing, and also works as expected with a https url.