-
-
Notifications
You must be signed in to change notification settings - Fork 846
Enable edge-to-edge support for BaseActivity #5387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Should the PR's status be changed to draft while we wait for the WebView changes, as those also extend BaseActivity? |
dshokouhi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested debug APK and looks good to me!
|
I believe it's related to strict mode rather than the code change in this PR, but the barcode scanner immediately crashes for me. |
jpelgrom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested most screens and didn't see any issues, code wise it also looks good to me.
Indeed it crashes for me too on main. The issue seems to come from wrong context being used. |
|
Tracked here journeyapps/zxing-android-embedded#762 but it seems that the lib is not maintained anymore. I'm going to ignore the issue for now. |
Summary
This PR enable edge-edge support at the BaseActivity level. It removes the indivual calls that were made in some other Base classes like for configure widget.
Checklist
Any other notes
Closes #5328. This is the final piece for the native screen of the app to support edge to edge.