Skip to content

Conversation

@TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Jun 3, 2025

Summary

This PR enable edge-edge support at the BaseActivity level. It removes the indivual calls that were made in some other Base classes like for configure widget.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Any other notes

Closes #5328. This is the final piece for the native screen of the app to support edge to edge.

@TimoPtr TimoPtr requested a review from jpelgrom June 3, 2025 12:37
@jpelgrom
Copy link
Member

jpelgrom commented Jun 3, 2025

Should the PR's status be changed to draft while we wait for the WebView changes, as those also extend BaseActivity?

@TimoPtr TimoPtr marked this pull request as draft June 4, 2025 06:16
@TimoPtr TimoPtr marked this pull request as ready for review July 16, 2025 08:08
Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested debug APK and looks good to me!

@jpelgrom
Copy link
Member

I believe it's related to strict mode rather than the code change in this PR, but the barcode scanner immediately crashes for me.

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested most screens and didn't see any issues, code wise it also looks good to me.

@TimoPtr
Copy link
Member Author

TimoPtr commented Jul 17, 2025

I believe it's related to strict mode rather than the code change in this PR, but the barcode scanner immediately crashes for me.

Indeed it crashes for me too on main. The issue seems to come from wrong context being used.

@TimoPtr TimoPtr merged commit 09fc91c into main Jul 17, 2025
19 checks passed
@TimoPtr TimoPtr deleted the feature/edge-to-edge_baseactivity branch July 17, 2025 06:27
@TimoPtr
Copy link
Member Author

TimoPtr commented Jul 17, 2025

Tracked here journeyapps/zxing-android-embedded#762 but it seems that the lib is not maintained anymore. I'm going to ignore the issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edge to edge support is enabled by default

4 participants