Skip to content

Conversation

@ianthomas23
Copy link
Member

This separates out the where reduction combine_cpu functions by number of array dimensions, which may be 2, 3 or 4 depending on whether they contain categorical and/or a *_n selector reductions. This is the same as already done for the combine_cuda functions.

@ianthomas23 ianthomas23 added this to the v0.15.2 milestone Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1265 (3edd83a) into main (7e3b8c3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1265      +/-   ##
==========================================
+ Coverage   83.44%   83.47%   +0.03%     
==========================================
  Files          35       35              
  Lines        9071     9089      +18     
==========================================
+ Hits         7569     7587      +18     
  Misses       1502     1502              
Files Changed Coverage Δ
datashader/reductions.py 80.34% <100.00%> (+0.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 merged commit 812bcf6 into holoviz:main Aug 8, 2023
@ianthomas23 ianthomas23 deleted the separate_where_combine_cpu_funcs branch August 8, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants