Simplify aliases and import new cmaps from Dec 2020#65
Simplify aliases and import new cmaps from Dec 2020#65jbednar merged 24 commits intoholoviz:masterfrom
Conversation
…Vs, make aliases a dict of lists
…tnames for CET_to_py.py
|
Since |
|
Just FYI I'm still planning to finish this ASAP. Work has kept me busy. |
|
Cool, thanks. I'm excited to see these made available, but no rush! |
|
I'd guess you're still busy, but just checking in to see if you know when this can get wrapped up? I'd love to make a new release so people can use this cool stuff! |
@jbednar Yes, sorry to leave it hanging for so long. I'll spend a few hours today and see if I can get it submitted. |
|
Ok, I apparently was like 99.9999% finished. 😳🤦🏼♂️ Unless I've forgotten something major since last touching this! I guess I didn't really touch the docs at all which you may want to do. |
|
This is ready to go, from my end. |
jbednar
left a comment
There was a problem hiding this comment.
Thanks for all this work! I can't spot any problems with it, so now that CI isn't broken any more I'll merge it now and do more testing locally before making a release. Sorry for the long delay while we focused on Param!
|
@jbednar You're welcome! It was a fun pet project to take up. Also, Param looks amazing--I had not looked into it before. |
Summary
In Dec. 2020 Peter updated the CET colormaps. This PR contains multiple changes:
aliasesto a dict of lists. This simplifies the logic of finding all the aliases for a given name and makes it easy to add aliases for a given map.colorcet.mfrom Peter Kovesi, as well as at most one alias for any colormaps that do not yet have one.Notes
CET_name may in some cases be the only alias to a map, I have not removed those, though we talked about it previously. (Actually, I did at first, but then reverted the change). If someone wants to do this it's pretty easy--just removecetnames,cetnames_flipped, and anything that references those variables fromCET_to_py.py, rerunCET_to_py.pyand update the tests.colorcet.m(using MATLAB/Octave scriptmake_csvs_from_colorcet.m), sincecolorcet.mis the "upstream" of those CSVs. Some of the existing CSV colormaps in holoviz/colorcet don't exactly match what what's incolorcet.mbut what's already here is being left as-is.linear_kbc_5_95_c73instead oflinear_blue_5_95_c73. The old names (..._blue_...) may still be used.colorcet.mare at the top ofmake_csvs_from_colorcet.mandCET_merge.py.