-
Notifications
You must be signed in to change notification settings - Fork 74
implement Float64() float64
#132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 1607 1615 +8
=========================================
+ Hits 1607 1615 +8 |
name old time/op new time/op delta Float64/Float64/uint256-8 67.0µs ± 6% 63.1µs ± 5% -5.90% (p=0.032 n=5+5) Float64/Float64/big-8 55.5µs ± 7% 57.6µs ± 9% ~ (p=0.222 n=5+5) name old alloc/op new alloc/op delta Float64/Float64/uint256-8 29.5kB ± 0% 28.5kB ± 0% -3.47% (p=0.008 n=5+5) Float64/Float64/big-8 23.4kB ± 0% 23.4kB ± 0% ~ (all equal) name old allocs/op new allocs/op delta Float64/Float64/uint256-8 701 ± 0% 573 ± 0% -18.26% (p=0.008 n=5+5) Float64/Float64/big-8 510 ± 0% 510 ± 0% ~ (all equal)
name old time/op new time/op delta Float64/Float64/uint256-8 63.1µs ± 5% 3.6µs ±42% -94.26% (p=0.008 n=5+5) Float64/Float64/big-8 57.6µs ± 9% 60.0µs ± 8% ~ (p=0.421 n=5+5) name old alloc/op new alloc/op delta Float64/Float64/uint256-8 28.5kB ± 0% 0.0kB -100.00% (p=0.008 n=5+5) Float64/Float64/big-8 23.4kB ± 0% 23.4kB ± 0% ~ (all equal) name old allocs/op new allocs/op delta Float64/Float64/uint256-8 573 ± 0% 0 -100.00% (p=0.008 n=5+5) Float64/Float64/big-8 510 ± 0% 510 ± 0% ~ (all equal)
Owner
Author
|
Float64() float64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #123
This PR implements
Implementing
Float64makes it possible to use e.g. the logarithm functions in themathpackage.Todo:
big