changes put to return key and value passed #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafintosh
reviewed
May 13, 2022
test/all.js
Outdated
| for (const test of tests) { | ||
| const feed = new Hypercore(require('random-access-memory')) | ||
| const db = new Hyperbee(feed, test.opts) | ||
| await db.ready() |
mafintosh
reviewed
May 13, 2022
test/all.js
Outdated
| const Hypercore = require('hypercore') | ||
| for (const test of tests) { | ||
| const feed = new Hypercore(require('random-access-memory')) | ||
| const db = new Hyperbee(feed, test.opts) |
mafintosh
reviewed
May 13, 2022
test/all.js
Outdated
| await db.ready() | ||
| const result = await db.put(test.key, test.value) | ||
| test.t(result, test.key, test.value) | ||
| } |
There was a problem hiding this comment.
actually this loop doesn't help much with clarity. just duplicate the creation between three independent tests instead and use the create helper :)
|
Came here looking for this functionality 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows put to return the key and value passed to it upon a successful write.