Add Oracle Solaris 11 support #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodebrew
Outdated
Alhadis
suggested changes
Sep 1, 2022
| } | ||
|
|
||
| sub _cmd_install_binary { | ||
| error_and_exit("Does not supported on Oracle Solaris. This option supports only illumos kernel distribution. \n") if $^O eq 'solaris'; |
There was a problem hiding this comment.
Suggested change
| error_and_exit("Does not supported on Oracle Solaris. This option supports only illumos kernel distribution. \n") if $^O eq 'solaris'; | |
| error_and_exit("Node.js does not support Oracle Solaris. Only illumos-based distributions are supported.\n") if $^O eq 'solaris'; |
| my $tarball_path = "$src_dir/$target_name.tar.gz"; | ||
|
|
||
| if ($^O eq 'solaris' && $self->get_type eq 'iojs') { | ||
| error_and_exit("io.js does not supported on $^O \n"); |
There was a problem hiding this comment.
Suggested change
| error_and_exit("io.js does not supported on $^O \n"); | |
| error_and_exit("io.js is not supported on $^O \n"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Add a fix that to support Oracle Solaris 11. (Check the Solaris 11.3)
thanks,
Kazuyuki