Skip to content

Conversation

@wzq016
Copy link
Contributor

@wzq016 wzq016 commented Feb 25, 2025

The current template does not have <|vision_start|> and <|vision_end|> tags when computing log probs.

This change is consistent with Llama-Factory.

Fix template issue
@hiyouga hiyouga self-requested a review February 25, 2025 20:26
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit 62958ee into hiyouga:main Feb 25, 2025
1 check passed
hiyouga pushed a commit that referenced this pull request Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants