WIP: Receipt parameter (not required). Add OutSumCurrency parameter, rename currency label parameter #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilverFire
reviewed
Apr 30, 2019
| 'SignatureValue' => $this->generateSignature(), | ||
| 'IsTest' => (int)$this->getTestMode(), | ||
| 'IsTest' => (int) $this->getTestMode(), | ||
| 'Receipt' => $this->getReceipt(), |
Member
There was a problem hiding this comment.
Тут не страшно, если возвращаемое значение будет null?
Contributor
Author
There was a problem hiding this comment.
Не важно. Если Receipt null или не верный (важна очередность параметров по документации), то он просто игнорируется.
Member
|
Спасибо! |
Contributor
Author
|
Пока лучше подождать. Есть вопрос с URL кодированием (по документации) параметра Receipt. Этот параметр не проходит, разбираемся в чём проблема. |
SilverFire
changed the title
Member
|
Ок, повесил Work In Progress. Дайте знать, как будете готовы |
Contributor
Author
|
Можно мержить. Всё проверил, параметры проходят. |
SilverFire
approved these changes
May 13, 2019
Member
|
Спасибо, принято |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения потребуют перенастройки на всех сайтах, которые используют этот компонент, но я думаю это необходимо для развития компонента.