Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Conversation

@himynameisdave
Copy link
Owner

If I'm not mistaken, Github paginates results for labels to 30 items by default (https://developer.github.com/v3/#pagination ?).
I happen to have more than 30 labels, so when I create a package from labels, it only takes the 30 first labels.

I'll do the rest by hand, but it'll be cool if the labelmaker was able to pull all the labels.

@himynameisdave
Copy link
Owner

L:eyes:king into this one, thanks for reporting!

@himynameisdave
Copy link
Owner

himynameisdave commented Mar 18, 2017

Additionally, the labels that do come back are not ordered properly/as they appear in GitHub 👎

Looks like they come back alphabetically actually

@himynameisdave
Copy link
Owner

@GabrielCW thanks for reporting.

As of version v0.9.0 (which will hopefully be finished, merged and published soon!) the new limit will be 100, which should cover most repositories.

Beyond this, if we wanted we can parse the headers.link response to see if there is any pagination and account for, but for now I think 100 is a pretty high number and should avoid people running into problems with some not being downloaded to their new package file.

@himynameisdave himynameisdave merged commit 30be1e5 into v0.9.0 Mar 18, 2017
@himynameisdave himynameisdave deleted the issues/71 branch March 18, 2017 22:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants