Skip to content

Some issues if try to use it in a real life :) #37

@Denys88

Description

@Denys88

Hi, I tried to use your product but got a lot of small issues and found some lack of functionality.

  1. Please don't expect that git address is something line this:


    I tried to use it with the internal github which is different from public github and got an error.

  2. There are a lot of cases where your error messages are useless like in first example.
    I tried to use higgsfield manually and got a lot of messages like 'something is not a string'.
    Quick debug helped me to find that I forgot or put wrong command line parameter. It could be improved.

  3. LLama and hugging face:

    tokenizer=LlamaTokenizer.from_pretrained("meta-llama/Llama-2-7b-hf"),

    When I import llama loader it automatically tries to get access to the HF without any my permitions. Overall trying to access something from internet without explicit calls is a big red flag from the security of view. In my case I've already downloaded everything and don't need to connect to the HG at all.

  4. Would be nice to see more examples:

  • very simple manually implemented architecture which supports deepspeed/zero distribution training.
  • example which show how to manually run everything without github and hf access.
  • ability to run your code on a single machine - single gpu and single machine multiple gpu too.
    Because how do you expect people to debug their code?
    I wanted to run a simple example without setting up my machines and using github and found it impossible which is a big problem in my opinion/

Overall great job and nice implementation but it could be much user friendlier.
Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions