-
Notifications
You must be signed in to change notification settings - Fork 86
feat: add TokenFeeScheduleUpdateTransaction class and tests #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TokenFeeScheduleUpdateTransaction class and tests #722
Conversation
Signed-off-by: Akshat Kumar <[email protected]>
Signed-off-by: Akshat8510 <[email protected]>
Signed-off-by: Akshat8510 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Akshat8510 please check there may be an error with one of the fields you are using
src/hiero_sdk_python/tokens/token_fee_schedule_update_transaction.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Akshat8510 <[email protected]>
Signed-off-by: Akshat8510 <[email protected]>
Signed-off-by: Akshat8510 <[email protected]>
Signed-off-by: Akshat8510 <[email protected]>
Signed-off-by: Akshat8510 <[email protected]>
tests/integration/test_token_fee_schedule_update_transaction_e2e.py
Outdated
Show resolved
Hide resolved
|
Hi @Akshat8510, just a few small changes required rest looks good |
Signed-off-by: Akshat8510 <[email protected]>
Signed-off-by: Akshat8510 <[email protected]>
Signed-off-by: Akshat8510 <[email protected]>
Signed-off-by: Akshat8510 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Akshat8510, just a small changes please remove the supply key and add sys.exit(1) call in both examples to ensure the program terminates with an error status whenever it fails.
Signed-off-by: Akshat8510 <[email protected]>
Signed-off-by: Akshat8510 <[email protected]>
Signed-off-by: Akshat8510 <[email protected]>
|
Looks Good to me. |
|
Congratulations @Akshat8510 and thank you so much! |
Title: feat: Add TokenFeeScheduleUpdateTransaction class and tests
Description:
This PR introduces the
TokenFeeScheduleUpdateTransactionclass, enabling users to update the custom fee schedule for existing tokens.TokenFeeScheduleUpdateTransactionclassexamples/token_update_fee_schedule_fungible.pyandexamples/token_update_fee_schedule_nft.pydocs/sdk_users/running_examples.mdandCHANGELOG.mdRelated issue(s):
Fixes #471
Notes for reviewer:
Checklist: