Skip to content

Conversation

@Akshat8510
Copy link
Contributor

Title: feat: Add TokenFeeScheduleUpdateTransaction class and tests


Description:
This PR introduces the TokenFeeScheduleUpdateTransaction class, enabling users to update the custom fee schedule for existing tokens.

  • Add TokenFeeScheduleUpdateTransaction class
  • Add unit tests (setters, chaining, edge cases)
  • Add integration tests (success, failure cases, protocol validation)
  • Split example scripts into examples/token_update_fee_schedule_fungible.py and examples/token_update_fee_schedule_nft.py
  • Update docs/sdk_users/running_examples.md and CHANGELOG.md

Related issue(s):
Fixes #471


Notes for reviewer:

  • Implementation aligns with other token transaction types for consistency.
  • Integration tests validate both fungible and NFT token updates.
  • Documentation and examples verified locally.

Checklist:

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Akshat8510 please check there may be an error with one of the fields you are using

exploreriii
exploreriii previously approved these changes Nov 4, 2025
@manishdait
Copy link
Contributor

Hi @Akshat8510, just a few small changes required rest looks good

Copy link
Contributor

@manishdait manishdait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Akshat8510, just a small changes please remove the supply key and add sys.exit(1) call in both examples to ensure the program terminates with an error status whenever it fails.

@Akshat8510 Akshat8510 requested a review from manishdait November 6, 2025 14:16
@manishdait
Copy link
Contributor

Looks Good to me.

@exploreriii exploreriii merged commit 8d592d7 into hiero-ledger:main Nov 6, 2025
12 checks passed
@exploreriii
Copy link
Contributor

Congratulations @Akshat8510 and thank you so much!

@Akshat8510 Akshat8510 deleted the feat/token-fee-schedule-update-v2 branch November 6, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TokenFeeScheduleUpdateTransaction

3 participants