Skip to content

Conversation

@Raja-89
Copy link
Contributor

@Raja-89 Raja-89 commented Nov 2, 2025

Summary

This PR adds a new developer documentation file at
docs/sdk_developers/pylance.md.

The document introduces Pylance, a powerful VS Code language server for Python, and guides contributors on how to set it up and interpret its diagnostics to improve code quality before submitting pull requests.


Details

Added

  • docs/sdk_developers/pylance.md
    • Explains what Pylance is and why it’s important for the Hiero SDK Python repository.
    • Includes setup instructions for enabling and customizing Pylance in VS Code.
    • Demonstrates how to interpret Pylance error messages using real examples from the SDK.
    • Provides reference links to the SDK’s contributing guidelines, changelog, and commit signing documentation.

✅ Checklist

  • Documentation added under docs/sdk_developers/
  • Commit signed and verified (git commit -S -s -m "...")
  • Changelog entry added
  • Markdown formatting validated and linted
  • Follows repository contribution guidelines

🔗 References


Closes: #713

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raja-89 please check your difference between your submission and our main, each time, before requesting a review!
You can see you've deleted a changelog entry
https://github.com/hiero-ledger/hiero-sdk-python/pull/718/files#r2484971770

@Raja-89
Copy link
Contributor Author

Raja-89 commented Nov 3, 2025

@exploreriii , resolved

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both methods work, there is no incorrect in this

@Raja-89
Copy link
Contributor Author

Raja-89 commented Nov 3, 2025

Both methods work, there is no incorrect in this

Hey @exploreriii , let me know...
What should be my next step?
Do we need the changes or keep it asit is ?

@exploreriii
Copy link
Contributor

@Raja-89 you are claiming the top one is incorrect, but its actually correct
The bottom one is correct as well

So you don't have an 'incorrect' example

@Raja-89
Copy link
Contributor Author

Raja-89 commented Nov 3, 2025

Hey @exploreriii
I’ve updated the Fixing Invalid Imports and Calls section as per your feedback.
It now correctly distinguishes between /src and /examples import usage with clear context and examples.

I’ve also synced my branch with the latest upstream changes everything should now be up to date.

Please review it once and let me know if any further refinements are needed.

@Raja-89
Copy link
Contributor Author

Raja-89 commented Nov 4, 2025

Thanks @exploreriii ,got it!
I’ve updated the section to first show an invalid import example (from hiero_sdk.account.account_id import AccountId) and then corrected it with both valid forms (for /src and /examples).

@exploreriii exploreriii merged commit 00ac75a into hiero-ledger:main Nov 4, 2025
11 checks passed
@exploreriii
Copy link
Contributor

Thanks a lot, appreciate all the efforts! @Raja-89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants