-
Notifications
You must be signed in to change notification settings - Fork 86
feat: Refactor AbstractTokenTransferTransaction to unify Token/NFT transfer logic
#710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor AbstractTokenTransferTransaction to unify Token/NFT transfer logic
#710
Conversation
src/hiero_sdk_python/tokens/abstract_token_transfer_transaction.py
Outdated
Show resolved
Hide resolved
|
yay! Thanks @manishdait, with this we get rid of quite a lot of duplicate code. Awesome work! |
583b55d to
10d0607
Compare
|
Hi @manishdait note we have two airdrop examples that ran, but we have just merged two more. ************ examples/token_airdrop.py ************ Creating a new account... Creating a token... Creating a nft... Minting a nft... Associating tokens to recipient... ✅ Success! Token association complete. Airdropping tokens... ✅ Success! Token Airdrop transaction successful ************ examples/token_airdrop_cancel.py ************ Creating a new account... Creating token: First Token (TKA)... Creating token: Second Token (TKB)... Airdropping tokens... Canceling airdrops... |
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
Signed-off-by: Manish Dait <[email protected]>
10d0607 to
1bffe80
Compare
…transfer logic (hiero-ledger#710) Signed-off-by: Manish Dait <[email protected]> Signed-off-by: MonaaEid <[email protected]>
Description:
This PR refactors
AbstractTokenTransferTransactionto unified the common logic of creatingTokenTransferList, forTransferTransactionandTokenAirdropTransaction.Changes Made:
AbstractTokenTransactionclass.TransferTransactionandTokenAirdropTransactionclass.Related issue(s):
Fixes #404
Notes for reviewer:
Checklist