-
Notifications
You must be signed in to change notification settings - Fork 86
chore: remove hardcoded testnet messages #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: remove hardcoded testnet messages #670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much, we require a changelog entry (see changelog.md) and all commits to be verified (see signing.md).
Thanks so much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your latest commit is not verified
i'd recommend reverting and signing again
git reset --soft HEAD~4
git commit -S -s - m "....."
Signed-off-by: ekarvou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @elsakarvouni an update working on examples was pushed, but you will need to rebase (see rebasing.md) and resolve some conflicts (see merge_conflicts.md).
It is a good opportunity to learn how to do that, but if it is difficult i'd recommend starting a fresh copy

Removed all hardcoded messages connecting to Hedera testnet.
Now the network is read from .env (NETWORK variable), so the message dynamically shows which network the user is connecting to.