Skip to content

feat: add TokenClaimAirdropTransaction Transaction #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

feat: add TokenClaimAirdropTransaction Transaction #213

wants to merge 10 commits into from

Conversation

@exploreriii
Copy link
Contributor

@exploreriii exploreriii commented Jul 22, 2025 •
edited
Loading

This PR is ready for review
Will close #201

0xivanov
0xivanov reviewed Jul 24, 2025
View reviewed changes
@exploreriii

This comment was marked as outdated.

Sign in to view
@exploreriii

This comment was marked as outdated.

Sign in to view
@exploreriii exploreriii force-pushed the feat-addPendingAirdropId branch 3 times, most recently from bc9431e to 5019190 Compare August 20, 2025 13:38
@exploreriii

This comment was marked as outdated.

Sign in to view
@exploreriii

This comment was marked as outdated.

Sign in to view
@exploreriii exploreriii force-pushed the feat-addPendingAirdropId branch from 5019190 to 1e2acd0 Compare September 6, 2025 21:27
@exploreriii

This comment was marked as outdated.

Sign in to view
@exploreriii

This comment was marked as outdated.

Sign in to view
@nadineloepfe
Copy link
Contributor

nadineloepfe commented Oct 6, 2025

heyhey @exploreriii, what's the latest on this?

@exploreriii
Copy link
Contributor Author

exploreriii commented Oct 6, 2025

Really improved the examples a lot and have to finish up the integration test

@exploreriii exploreriii force-pushed the feat-addPendingAirdropId branch from 1e2acd0 to 6ecdc57 Compare October 6, 2025 15:57
@exploreriii exploreriii marked this pull request as ready for review October 6, 2025 17:25
@exploreriii exploreriii changed the title feat: add TokenPendingAirdrop Transaction feat: add TokenClaimAirdropTransaction Transaction Oct 6, 2025
@exploreriii exploreriii force-pushed the feat-addPendingAirdropId branch from cd0d84c to d9db318 Compare October 7, 2025 13:07
@exploreriii
chore: token claim airdrop examples
17cfa57 
Signed-off-by: exploreriii <[email protected]>
@exploreriii
feat: max token associations to account creation
84e12ef 
Signed-off-by: exploreriii <[email protected]>
@exploreriii
chore: token airdrop claim unit and integration tests
0599475 
Signed-off-by: exploreriii <[email protected]>
@exploreriii
refactor: rename of token airdrop related modules
6460f48 
Signed-off-by: exploreriii <[email protected]>
@exploreriii
refactor: add detail to str and repr method in token pending
892a9e9 
Signed-off-by: exploreriii <[email protected]>
@exploreriii
feat: token airdrop claim
fcd5744 
Signed-off-by: exploreriii <[email protected]>
@exploreriii
chore: changelog update
6bf30b3 
Signed-off-by: exploreriii <[email protected]>
@exploreriii
chore: codacy log balance cyclo complexity
499e5ed 
Signed-off-by: exploreriii <[email protected]>
@exploreriii
chore: reduce lines of code
6a51b16 
Signed-off-by: exploreriii <[email protected]>
@exploreriii
chore: fix duplicate changelog entry
8a24eb8 
Signed-off-by: exploreriii <[email protected]>
@exploreriii exploreriii force-pushed the feat-addPendingAirdropId branch from d9db318 to 8a24eb8 Compare October 7, 2025 13:24
@nadineloepfe
Copy link
Contributor

nadineloepfe commented Oct 28, 2025

hey @exploreriii
what;s the latest on this one?

@exploreriii
Copy link
Contributor Author

exploreriii commented Oct 28, 2025

Hi, it was finished at the time, maybe can benefit from some touch ups but also should be fairly good

@exploreriii
Copy link
Contributor Author

exploreriii commented Oct 28, 2025

I'll make the file name changes a different PR to make it clearer

nadineloepfe
nadineloepfe approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@nadineloepfe nadineloepfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tests passing and example works perfectly. Thank you for this PR, and apologies for the delay in getting this reviewed - I thought it was still in progress

@nadineloepfe
Copy link
Contributor

nadineloepfe commented Oct 29, 2025

but rebase please :D

@exploreriii
Copy link
Contributor Author

exploreriii commented Oct 29, 2025

Got it!
I have opened a short good first issue which is nearly complete to change the airdrop transaction files, which this PR does anyway. When I rebase it should then be a lot tidier - my changes just adding on to the files we already have. It will be better documented I think in this way.

@exploreriii
Copy link
Contributor Author

exploreriii commented Nov 4, 2025

Closing, reopening

@exploreriii exploreriii closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nadineloepfe nadineloepfe nadineloepfe approved these changes

+1 more reviewer

@0xivanov 0xivanov 0xivanov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add TokenClaimAirdropTransaction

3 participants

@exploreriii @nadineloepfe @0xivanov