-
Notifications
You must be signed in to change notification settings - Fork 134
Convert exchange rate API to Java #12166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Steven Sheehy <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Signed-off-by: Steven Sheehy <[email protected]>
rest-java/src/main/java/org/hiero/mirror/restjava/controller/NetworkController.java
Show resolved
Hide resolved
Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Xin Li <[email protected]>
rest-java/src/main/java/org/hiero/mirror/restjava/service/FileServiceImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
In the CI logs I see: |
That's expected since the acceptance workflow uses v0.139.0-rc3. I'l check why the exchangerate requests are routed to rest-java, we may want to enable it later when an image becomes available, otherwise the workflow will always fail. |
Description:
/api/v1/network/exchangerateto rest-java moduleroutes.exchangeRatewith a default of false to Helm chartRelated issue(s):
Fixes #12101
Notes for reviewer:
Checklist