Skip to content

Conversation

@steven-sheehy
Copy link
Contributor

@steven-sheehy steven-sheehy commented Oct 11, 2025

Description:

  • Add /api/v1/network/exchangerate to rest-java module
  • Add k6 tests for rest-java exchange rate
  • Add routes.exchangeRate with a default of false to Helm chart
  • Change acceptance tests to route to both old and new endpoints
  • Fix timestamp parameter regex in openapi.yml
  • Resolve cross-site scripting attacks by not printing request values to response on validation failure

Related issue(s):

Fixes #12101

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added this to the 0.141.0 milestone Oct 11, 2025
@steven-sheehy steven-sheehy self-assigned this Oct 11, 2025
@steven-sheehy steven-sheehy added enhancement Type: New feature technical debt rest-java Area: Java REST API labels Oct 11, 2025
@lfdt-bot
Copy link

lfdt-bot commented Oct 11, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Oct 11, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-31.32% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (18ef799) 36925 33636 91.09%
Head commit (c8e94e2) 61006 (+24081) 36466 (+2830) 59.77% (-31.32%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#12166) 64 64 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Signed-off-by: Steven Sheehy <[email protected]>
@xin-hedera xin-hedera marked this pull request as ready for review October 14, 2025 19:33
@xin-hedera xin-hedera requested a review from a team as a code owner October 14, 2025 19:33
@xin-hedera xin-hedera requested a review from nirbosl October 14, 2025 19:33
Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bilyana-gospodinova
Copy link
Contributor

In the CI logs I see:
GET /api/v1/network/exchangerate in 3 ms: 404 No static resource
Perhaps something's missing.

@xin-hedera
Copy link
Contributor

In the CI logs I see: GET /api/v1/network/exchangerate in 3 ms: 404 No static resource Perhaps something's missing.

That's expected since the acceptance workflow uses v0.139.0-rc3.

I'l check why the exchangerate requests are routed to rest-java, we may want to enable it later when an image becomes available, otherwise the workflow will always fail.

@xin-hedera xin-hedera merged commit a87626d into main Oct 16, 2025
37 of 42 checks passed
@xin-hedera xin-hedera deleted the 12101-exchangerate-restjava branch October 16, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Type: New feature rest-java Area: Java REST API technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert /network/exchangerate to Java

7 participants