Return null in case token with negative num value is being read #12124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
IvanKavaldzhiev
changed the title
steven-sheehy
requested changes
Oct 3, 2025
web3/src/main/java/org/hiero/mirror/web3/state/keyvalue/TokenReadableKVState.java
Outdated
Show resolved
Hide resolved
web3/src/test/java/org/hiero/mirror/web3/service/ContractCallAirdropSystemContractTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…-invalid-token-id
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
web3/src/main/java/org/hiero/mirror/web3/state/keyvalue/TokenReadableKVState.java
Outdated
Show resolved
Hide resolved
…-invalid-token-id
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
web3/src/test/java/org/hiero/mirror/web3/service/ContractCallAirdropSystemContractTest.java
Outdated
Show resolved
Hide resolved
…-invalid-token-id
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
jnels124
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It seems users are passing evm address value as token addresses, which results to decoding them in a very big number that overflows Long type and produces TokenID with negative num value.
In case of such a wrong input in the calldata this PR returns null, instead of trying to decode this TokenID, the PR changes the logic to just return a null value and most likely lead to the transaction getting reverted. This will also clear out Grafana logs with unnecessary exception statements.
Fixes #12082
Checklist