Skip to content

Conversation

@xin-hedera
Copy link
Contributor

@xin-hedera xin-hedera commented Oct 3, 2025

Description:

This PR add logic to link schedule transactions and its trigger in BlockStreamReader

  • Link short-term scheduled transactions and its triggering transaction
  • Delegate to the tigger's StateChangeContext when available

Related issue(s):

Fixes #12091

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@xin-hedera xin-hedera added this to the 0.141.0 milestone Oct 3, 2025
@xin-hedera xin-hedera self-assigned this Oct 3, 2025
@xin-hedera xin-hedera requested a review from a team as a code owner October 3, 2025 18:04
@xin-hedera xin-hedera requested a review from filev94 October 3, 2025 18:04
@xin-hedera xin-hedera added bug Type: Something isn't working importer Area: Importer labels Oct 3, 2025
@lfdt-bot
Copy link

lfdt-bot commented Oct 3, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@codacy-production
Copy link

codacy-production bot commented Oct 3, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-31.44% (target: -1.00%) 95.45%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a893f6e) 36899 33614 91.10%
Head commit (430e463) 60900 (+24001) 36333 (+2719) 59.66% (-31.44%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#12123) 22 21 95.45%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

steven-sheehy
steven-sheehy previously approved these changes Oct 3, 2025
…d-transactions-and-relevant-statechanges

Signed-off-by: Xin Li <[email protected]>
Copy link
Contributor

@IvanKavaldzhiev IvanKavaldzhiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xin-hedera xin-hedera merged commit 46d9234 into main Oct 8, 2025
32 of 34 checks passed
@xin-hedera xin-hedera deleted the 12091-hip-1056-missing-link-between-scheduled-transactions-and-relevant-statechanges branch October 8, 2025 13:53
bilyana-gospodinova pushed a commit that referenced this pull request Oct 10, 2025
- Link short-term scheduled transactions and its triggering transaction
- Delegate to the tigger's StateChangeContext when available

Signed-off-by: Xin Li <[email protected]>
bilyana-gospodinova pushed a commit that referenced this pull request Oct 10, 2025
- Link short-term scheduled transactions and its triggering transaction
- Delegate to the tigger's StateChangeContext when available

Signed-off-by: Xin Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Type: Something isn't working importer Area: Importer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HIP-1056 Missing link between scheduled transactions and relevant statechanges

5 participants