Adapt acceptance tests to use estimate gas query from SDK (#11183) #11432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In java SDK there is a MirrorNodeContractEstimateGasQuery which can be used for gas estimation queries. Currently we perform manually a contract call with given parameters. This PR refactors the acceptance tests to use estimate query instead of manual contract call --------- Signed-off-by: Nikolay Nikolov <[email protected]>
nickeynikolovv
added
enhancement
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Signed-off-by: Nikolay Nikolov <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Signed-off-by: Nikolay Nikolov <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…y-to-the-acceptance-tests
|
Seems like some issue in CI acceptance tests around ledger ID and changes in PR |
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…y-to-the-acceptance-tests
…y-to-the-acceptance-tests
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…y-to-the-acceptance-tests
test/src/test/java/org/hiero/mirror/test/e2e/acceptance/client/MirrorNodeClient.java
Outdated
Show resolved
Hide resolved
test/src/test/java/org/hiero/mirror/test/e2e/acceptance/client/MirrorNodeClient.java
Outdated
Show resolved
Hide resolved
test/src/test/java/org/hiero/mirror/test/e2e/acceptance/steps/AbstractEstimateFeature.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
bilyana-gospodinova
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In java SDK there is a MirrorNodeContractEstimateGasQuery which can be used for gas estimation queries. Currently we perform manually a contract call with given parameters. This PR refactors the acceptance tests to use estimate query instead of manual contract call
Fixes #11152
Notes for reviewer:
Should not merge before modularized is 100% on all environments
Checklist