Skip to content

test: Test with real S3 bucket#2851

Open
ivannov wants to merge 3 commits into
mainfrom
2810-s3-archive-it
Open

test: Test with real S3 bucket#2851
ivannov wants to merge 3 commits into
mainfrom
2810-s3-archive-it

Conversation

@ivannov
Copy link
Copy Markdown
Contributor

@ivannov ivannov commented May 19, 2026

Reviewer Notes

This PR adds a one-shot integration test for CloudStorageArchivePlugin that exercises the full plugin lifecycle against a real S3-compatible bucket. The test is @disabled by default and skips automatically if a credentials properties file (~/.hedera/cloud-archive-integration-test.properties) is absent.

Supporting changes:

  • Config prefix fix: CloudStorageArchiveConfig was annotated @ConfigData("cloud.archive") but the env var convention uses CLOUD_STORAGE_ARCHIVE_*. The prefix is corrected to cloud.storage.archive, and the docs table + existing tests are updated to match.
  • update-env.sh: propagates the CLOUD_STORAGE_ARCHIVE_* env vars into the Docker .env file so the archive plugin can be configured for local Docker testing.

Related Issue(s)

Closes #2810

@ivannov ivannov added this to the 0.35.0 milestone May 19, 2026
@ivannov ivannov self-assigned this May 19, 2026
@ivannov ivannov requested review from a team as code owners May 19, 2026 11:51
@ivannov ivannov added Tests issue related to enhancing the tests Block Node Issues/PR related to the Block Node. labels May 19, 2026
ata-nas
ata-nas previously approved these changes May 20, 2026
Copy link
Copy Markdown
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

}

@Test
@Disabled // remove this if you want to run the test
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be able to put @Disable globally on class level. In that way all tests are disabled by default. I know we have only one test, but adding others here will disable them by default.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't plan to have this test at all pushed.

But its goal is to be a one-shot tests, that is one method only.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to have this in the codebase, and I tend to agree with Atanas that disabling the class might be worthwhile.

My thought is that while we have a single test here, we may find it worthwhile to add a few more that use real S3 services and we might use that in a "qualification" test process wherein we occasionally run this (manually or via well secured automation) to ensure that both existing S3 services and any new S3 services work as expected.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled the whole test class

AlfredoG87
AlfredoG87 previously approved these changes May 20, 2026
Copy link
Copy Markdown
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivannov ivannov dismissed stale reviews from AlfredoG87 and ata-nas via 782042a May 21, 2026 07:24
@ivannov ivannov force-pushed the 2810-s3-archive-it branch from a2e5431 to 782042a Compare May 21, 2026 07:24
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff              @@
##               main    #2851      +/-   ##
============================================
- Coverage     81.58%   81.47%   -0.11%     
+ Complexity     1559     1557       -2     
============================================
  Files           144      144              
  Lines          7413     7413              
  Branches        777      777              
============================================
- Hits           6048     6040       -8     
- Misses         1042     1050       +8     
  Partials        323      323              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Block Node Issues/PR related to the Block Node. Tests issue related to enhancing the tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test with real S3 bucket

4 participants