test: Test with real S3 bucket#2851
Conversation
| } | ||
|
|
||
| @Test | ||
| @Disabled // remove this if you want to run the test |
There was a problem hiding this comment.
I think we should be able to put @Disable globally on class level. In that way all tests are disabled by default. I know we have only one test, but adding others here will disable them by default.
There was a problem hiding this comment.
I didn't plan to have this test at all pushed.
But its goal is to be a one-shot tests, that is one method only.
There was a problem hiding this comment.
It's good to have this in the codebase, and I tend to agree with Atanas that disabling the class might be worthwhile.
My thought is that while we have a single test here, we may find it worthwhile to add a few more that use real S3 services and we might use that in a "qualification" test process wherein we occasionally run this (manually or via well secured automation) to ensure that both existing S3 services and any new S3 services work as expected.
There was a problem hiding this comment.
Disabled the whole test class
Signed-off-by: Ivan St. Ivanov <[email protected]>
Signed-off-by: Ivan St. Ivanov <[email protected]>
Signed-off-by: Ivan St. Ivanov <[email protected]>
a2e5431 to
782042a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2851 +/- ##
============================================
- Coverage 81.58% 81.47% -0.11%
+ Complexity 1559 1557 -2
============================================
Files 144 144
Lines 7413 7413
Branches 777 777
============================================
- Hits 6048 6040 -8
- Misses 1042 1050 +8
Partials 323 323 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Reviewer Notes
This PR adds a one-shot integration test for CloudStorageArchivePlugin that exercises the full plugin lifecycle against a real S3-compatible bucket. The test is @disabled by default and skips automatically if a credentials properties file (~/.hedera/cloud-archive-integration-test.properties) is absent.
Supporting changes:
Related Issue(s)
Closes #2810