chore: Followup to Issue 1626 #1829
Merged
+81
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsync-swirlds
requested review from
AlfredoG87,
Nana-EC,
ata-nas,
jasperpotts and
mustafauzunn
and removed request for
jasperpotts
Contributor
Author
|
@rockysingh, might be worth taking a look here; cannot easily add you to reviewers yet. |
Nana-EC
previously approved these changes
Nov 5, 2025
Contributor
Nana-EC
left a comment
Nana-EC
left a comment
There was a problem hiding this comment.
LG, minor suggestion if you circle back
...s/simulator/src/test/java/org/hiero/block/simulator/mode/PublisherClientModeHandlerTest.java
Outdated
Show resolved
Hide resolved
* Added explanatory comment * Removed many cases of `throws Exception` in tests that could (should) be specific so we catch new exceptions or unhandled failures * Replaced `new String(stdout, charset)` with `stdout.toString(charset)`. Signed-off-by: Joseph S. <[email protected]>
jsync-swirlds
force-pushed
the
1626-followup
branch
from
15d20dc to
909959a
Compare
Nana-EC
approved these changes
Nov 6, 2025
mustafauzunn
approved these changes
Nov 6, 2025
ata-nas
approved these changes
Nov 6, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1829 +/- ##
============================================
+ Coverage 81.37% 81.44% +0.07%
- Complexity 1164 1166 +2
============================================
Files 126 126
Lines 5428 5428
Branches 578 578
============================================
+ Hits 4417 4421 +4
+ Misses 751 749 -2
+ Partials 260 258 -2
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
throws Exceptionin tests that could (should) be specific so we catch new exceptions or unhandled failuresthrows ExceptionfromS3Client.close()that was forcing all users to catch or declareException.new String(stdout, charset)withstdout.toString(charset).