HHH-13884 Order.reverse() contract

[seregamorph]

https://hibernate.atlassian.net/browse/HHH-13884

backported in #3271

javax.persistence.criteria.Order.reverse() method javadoc explicitly declares that reverse() should return new instance.

[seregamorph]

please note: nullPrecenence duplicates precedence field.
nullPrecendence was assigned only in constructor and never used, all other access is done to precedence field.
I looks like a defect. I fixed it, because otherwise I could not write a test to validate all assignments in this class.

[sebersole]

I prefer the name nullPrecedence - its more consistent and self-documenting

[seregamorph]

fixed

[sebersole]

Minor request to change field name. Other than that - +1

[sebersole]

I prefer the name nullPrecedence - its more consistent and self-documenting

[seregamorph]

@sebersole requested change addressed. Still any objections to merge it?

[seregamorph]

@sebersole @beikov please make a decision on it. It was created half a year ago. If you don't like it, lets close.

[beikov]

Could you please rebase it, I can't merge it right now.

[seregamorph]

@beikov rebased on top of wip/6.0 and squashed into a single commit without changes.