Feature: Adds source_uri to all tests representing recipe's true URL#1688
Open
jknndy wants to merge 6 commits intohhursev:mainfrom
Open
Feature: Adds source_uri to all tests representing recipe's true URL#1688jknndy wants to merge 6 commits intohhursev:mainfrom
source_uri to all tests representing recipe's true URL#1688jknndy wants to merge 6 commits intohhursev:mainfrom
Conversation
Contributor
|
@jknndy this looks great to me; the improved scraper-maintenance/update possibilities should make a significant difference. I do think there could be some challenges ahead if+when we attempt more-automated retrieval and update of HTML from recipe websites -- perhaps use of archived/bulk download content (e.g. CommonCrawl) could help if we do run into problems. Even so, I think we should explore this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
& creates key using URL input through
generate.pyResolves #1246