Another minor cleanup for the read plan builder #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Nov 10, 2025
|
|
||
| let read_plan = plan_builder.build(); | ||
| .build_limited() | ||
| .build(); |
Author
There was a problem hiding this comment.
build() already calls preferred_selection_strategy so there isn't any reason to call it a second time here
Owner
There was a problem hiding this comment.
Also the issue from the last merge, let me also double check.
Owner
There was a problem hiding this comment.
That's correct, the method is double called. Thank you for your detail review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another small cleanup for the ReadPlan builder
Merging this PR will update the following PR:
cc @hhhizzz