Typedef Fixes#15
Closed
IkonOne wants to merge 10 commits intohexus:masterfrom
IkonOne:typedef-additions
Closed
Conversation
Added type definitions for the Arcade.Body 'slopes' member variable.
Added type definitions for the Arcade.Body 'slopes' member variable.
Closed
Owner
|
Nice, thank you. Looks good. Any chance this could be squashed into a single commit? |
Contributor
Author
|
Yah I'll do that tomorrow morning and resubmit. |
Owner
|
👌 |
Contributor
Author
|
Closing to create the new PR. |
Contributor
Author
|
@hexus If I didn't have all of the sloppy merging in that PR, would you not have been worried about flattening the PR? (That's the last time make a non-merge commit to master) |
Owner
|
Probably would've been okay, but I prefer just one commit per merge. Some projects I've seen like to see PRs sqashed to one commit per author where possible, and I kind of agree just for the sake of a concise history. I forgot that Github lets you swash everything into one commit by itself though, so I could have done that instead to save you redoing things! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for the typedefs.
There are some interfaces in the definition that are there solely for type validation. Otherwise it would be a bit of a pain in Typescript to create these objects. (BodySlopes, BodySlopesSat and SatSolverOptions).