web-terminal: use php helper for session auth lookup#5244
Merged
Conversation
Member
Author
|
https://github.com/numanturle said in Discord
that's a good start :) |
numanturle
approved these changes
Mar 8, 2026
Contributor
|
It looks good to me too, but if possible, I think we should probably change all the errors to "Unauthorized" unless in dev mode to make it harder to know what's wrong for a potential attacker. |
imjuniper
approved these changes
Mar 8, 2026
Member
Author
|
@imjuniper I understand where you're coming from, but hiding the difference between |
jaapmarcus
pushed a commit
that referenced
this pull request
Mar 16, 2026
* web-terminal: use php helper for session auth lookup * nit * Harde cookie parsing requested by https://github.com/numanturle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.