Adds .babelrc to .npmignore #132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using React Native which is not precompiled (nor most of its third party libraries) I need to apply babel to npm dependencies and since babel tries to use configs for each package if present, the presence of it here breaks my setup.
Contributor
|
What do you think about doing like reduxjs/react-redux#213 instead? |
Contributor
Author
|
Sure that works too, I'm kinda agnostic but there's already a |
Contributor
|
I'm not too opinionated about it, but since this was originally forked from react-redux (and sometimes used along side it), I like it keep things like this more or less the same. |
Contributor
Author
|
So, do you want a new PR? |
Contributor
|
That would be great :) |
Contributor
Author
|
Aight, opened a new PR, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using React Native which is not precompiled (nor most of its third party libraries) I need to apply babel to npm dependencies and since babel tries to use configs for each package if present, the presence of it here breaks my setup.