-
Notifications
You must be signed in to change notification settings - Fork 3
Enable libcnb tracing #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables `libcnb`'s `trace` feature, which means traces, spans, and events are written to OpenTelemetry export files on disk in the ephemeral build container, which can then be read by the Heroku build system or when debugging locally with Pack (so long as a suitable `--volume` mount has been configured). See: heroku/libcnb.rs#723 GUS-W-15148605.
edmorley
added a commit
that referenced
this pull request
Jan 23, 2025
GitHub recently announced ARM support when using their public runners: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ This means we don't need to use the custom runner group for ARM CI jobs any more, which have a slower boot time, since they don't have a warm slack pool of machines. For example the CI run in #320 has been waiting for 11 mins for a runner to be available: ``` Waiting for a runner to pick up this job... ```
This was referenced Jan 23, 2025
colincasey
approved these changes
Jan 23, 2025
edmorley
added a commit
that referenced
this pull request
Jan 23, 2025
GitHub recently announced ARM support when using their public runners: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ This means we don't need to use the custom runner group for ARM CI jobs any more, which have a slower boot time, since they don't have a warm slack pool of machines. For example the CI run in #320 has been waiting for 11 mins for a runner to be available: ``` Waiting for a runner to pick up this job... ``` GUS-W-17659818.
This was referenced Jan 23, 2025
heroku-linguist bot
added a commit
that referenced
this pull request
Feb 5, 2025
## heroku/python ### Added - Added `runtime.txt` support for the `python-3.X` major Python version form. ([#322](#322)) - Enabled `libcnb`'s `trace` feature. ([#320](#320)) ### Changed - The Python 3.13 version alias now resolves to Python 3.13.2. ([#326](#326)) - The Python 3.12 version alias now resolves to Python 3.12.9. ([#326](#326)) - Deprecated support for the `runtime.txt` file. ([#325](#325)) - Improved the error messages shown when the `.python-version` file contents aren't valid. ([#325](#325))
Merged
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Feb 5, 2025
## heroku/python ### Added - Added `runtime.txt` support for the `python-3.X` major Python version form. ([#322](heroku/buildpacks-python#322)) - Enabled `libcnb`'s `trace` feature. ([#320](heroku/buildpacks-python#320)) ### Changed - The Python 3.13 version alias now resolves to Python 3.13.2. ([#326](heroku/buildpacks-python#326)) - The Python 3.12 version alias now resolves to Python 3.12.9. ([#326](heroku/buildpacks-python#326)) - Deprecated support for the `runtime.txt` file. ([#325](heroku/buildpacks-python#325)) - Improved the error messages shown when the `.python-version` file contents aren't valid. ([#325](heroku/buildpacks-python#325))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
libcnb'stracefeature, which means traces, spans, and events are written to OpenTelemetry export files on disk in the ephemeral build container, which can then be read by the Heroku build system or when debugging locally with Pack (so long as a suitable--volumemount has been configured).See:
heroku/libcnb.rs#723
GUS-W-15148605.