Skip to content

Expand buildpack detection known file list#312

Merged
edmorley merged 1 commit intomainfrom
more-detection
Jan 6, 2025
Merged

Expand buildpack detection known file list#312
edmorley merged 1 commit intomainfrom
more-detection

Conversation

@edmorley
Copy link
Copy Markdown
Member

@edmorley edmorley commented Jan 3, 2025

This adds more Python project related file and directory names to the list recognised by buildpack detection. Such apps will still fail to build successfully (since they are missing a package manager file), but will now be shown a more helpful error message during compile, rather than the generic:
"No default language could be detected for this app"

The list is based on builds logs analysis of builds that filed to pass detection, plus builds that passed detection but didn't have a valid package manager file. (Possible since the build logs error message includes a file listing of the root directory of the app.)

This is the CNB equivalent of heroku/heroku-buildpack-python#1729.

GUS-W-17530142.

This adds more Python project related file and directory names
to the list recognised by buildpack detection. Such apps will still
fail to build successfully (since they are missing a package manager
file), but will now be shown a more helpful error message during
compile, rather than the generic:
"No default language could be detected for this app"

The list is based on builds logs analysis of builds that filed to pass
detection, plus builds that passed detection but didn't have a
valid package manager file. (Possible since the build logs error
message includes a file listing of the root directory of the app.)

GUS-W-17530142.
@edmorley edmorley added the enhancement New feature or request label Jan 3, 2025
@edmorley edmorley self-assigned this Jan 3, 2025
@edmorley edmorley marked this pull request as ready for review January 3, 2025 15:40
@edmorley edmorley requested a review from a team as a code owner January 3, 2025 15:40
@edmorley edmorley merged commit 871a132 into main Jan 6, 2025
@edmorley edmorley deleted the more-detection branch January 6, 2025 10:42
heroku-linguist bot added a commit that referenced this pull request Jan 8, 2025
## heroku/python

### Removed

- Removed support for Python 3.8. ([#313](#313))

### Changed

- Deprecated support for Python 3.9. ([#314](#314))
- Buildpack detection now recognises more Python-related file and directory names. ([#312](#312))
- Improved the error messages shown for EOL or unrecognised major Python versions. ([#313](#313))
@heroku-linguist heroku-linguist bot mentioned this pull request Jan 8, 2025
heroku-linguist bot added a commit to heroku/cnb-builder-images that referenced this pull request Jan 8, 2025
## heroku/python

### Removed

- Removed support for Python 3.8. ([#313](heroku/buildpacks-python#313))

### Changed

- Deprecated support for Python 3.9. ([#314](heroku/buildpacks-python#314))
- Buildpack detection now recognises more Python-related file and directory names. ([#312](heroku/buildpacks-python#312))
- Improved the error messages shown for EOL or unrecognised major Python versions. ([#313](heroku/buildpacks-python#313))
edmorley added a commit that referenced this pull request Oct 2, 2025
Similar to #312, this adds more files to the buildpack's
detection list - based on files commonly seen for apps
that fail detection due to eg misspelled files.

This is the CNB equivalent of:
heroku/heroku-buildpack-python#1914

GUS-W-19769734.
edmorley added a commit that referenced this pull request Oct 2, 2025
Similar to #312, this adds more files to the buildpack's
detection list - based on files commonly seen for apps
that fail detection due to eg misspelled files.

This is the CNB equivalent of:
heroku/heroku-buildpack-python#1914

GUS-W-19769734.
edmorley added a commit that referenced this pull request Oct 2, 2025
Similar to #312, this adds more files to the buildpack's
detection list - based on files commonly seen for apps
that fail detection due to eg misspelled files.

This is the CNB equivalent of:
heroku/heroku-buildpack-python#1914

GUS-W-19769734.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants