Skip to content

Conversation

@joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Dec 7, 2023

This adds the libcnb trace feature to some buildpacks. This will add traces, spans, and events into OpenTelemetry export files, which may be read by the heroku build system.

heroku/nodejs-function-invoker doesn't need the trace feature, since function builds occur in an environment that doesn't read tracing data.

@joshwlewis joshwlewis requested a review from a team as a code owner December 7, 2023 17:57
@joshwlewis joshwlewis enabled auto-merge (squash) December 7, 2023 18:23
@joshwlewis joshwlewis merged commit 3bb2a42 into main Dec 7, 2023
@joshwlewis joshwlewis deleted the add-libcnb-trace branch December 7, 2023 19:11
heroku-linguist bot added a commit to heroku/cnb-builder-images that referenced this pull request Dec 8, 2023
## heroku/nodejs

### Changed

- Updated `heroku/nodejs-corepack` to `2.5.0`.
- Updated `heroku/nodejs-engine` to `2.5.0`.
- Updated `heroku/nodejs-npm-engine` to `2.5.0`.
- Updated `heroku/nodejs-npm-install` to `2.5.0`.
- Updated `heroku/nodejs-pnpm-install` to `2.5.0`.
- Updated `heroku/nodejs-yarn` to `2.5.0`.

## heroku/nodejs-corepack

### Added

- Enabled libcnb `trace` feature, so that OpenTelemetry file exports with
  buildpack detect and build traces are emitted to the file system.
  ([#749](heroku/buildpacks-nodejs#749))

## heroku/nodejs-engine

### Added

- Added Node.js version 21.4.0.
- Enabled libcnb `trace` feature, so that OpenTelemetry file exports with
  buildpack detect and build traces are emitted to the file system.
  ([#749](heroku/buildpacks-nodejs#749))

## heroku/nodejs-function

### Changed

- Updated `heroku/nodejs-engine` to `2.5.0`.
- Updated `heroku/nodejs-function-invoker` to `2.5.0`.
- Updated `heroku/nodejs-npm` to `2.5.0`.

## heroku/nodejs-function-invoker

- No changes.

## heroku/nodejs-npm

- No changes.

## heroku/nodejs-npm-engine

### Added

- Added npm version 10.2.5.
- Enabled libcnb `trace` feature, so that OpenTelemetry file exports with
  buildpack detect and build traces are emitted to the file system.
  ([#749](heroku/buildpacks-nodejs#749))

## heroku/nodejs-npm-install

### Added

- Enabled libcnb `trace` feature, so that OpenTelemetry file exports with
  buildpack detect and build traces are emitted to the file system.
  ([#749](heroku/buildpacks-nodejs#749))

## heroku/nodejs-pnpm-install

### Added

- Enabled libcnb `trace` feature, so that OpenTelemetry file exports with
  buildpack detect and build traces are emitted to the file system.
  ([#749](heroku/buildpacks-nodejs#749))

## heroku/nodejs-yarn

### Added

- Enabled libcnb `trace` feature, so that OpenTelemetry file exports with
  buildpack detect and build traces are emitted to the file system.
  ([#749](heroku/buildpacks-nodejs#749))

Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
colincasey pushed a commit that referenced this pull request Dec 14, 2023
## heroku/nodejs

### Changed

- Updated `heroku/nodejs-corepack` to `2.5.0`.
- Updated `heroku/nodejs-engine` to `2.5.0`.
- Updated `heroku/nodejs-npm-engine` to `2.5.0`.
- Updated `heroku/nodejs-npm-install` to `2.5.0`.
- Updated `heroku/nodejs-pnpm-install` to `2.5.0`.
- Updated `heroku/nodejs-yarn` to `2.5.0`.

## heroku/nodejs-corepack

### Added

- Enabled libcnb `trace` feature, so that OpenTelemetry file exports with
  buildpack detect and build traces are emitted to the file system.
  ([#749](#749))

## heroku/nodejs-engine

### Added

- Added Node.js version 21.4.0.
- Enabled libcnb `trace` feature, so that OpenTelemetry file exports with
  buildpack detect and build traces are emitted to the file system.
  ([#749](#749))

## heroku/nodejs-function

### Changed

- Updated `heroku/nodejs-engine` to `2.5.0`.
- Updated `heroku/nodejs-function-invoker` to `2.5.0`.
- Updated `heroku/nodejs-npm` to `2.5.0`.

## heroku/nodejs-function-invoker

- No changes.

## heroku/nodejs-npm

- No changes.

## heroku/nodejs-npm-engine

### Added

- Added npm version 10.2.5.
- Enabled libcnb `trace` feature, so that OpenTelemetry file exports with
  buildpack detect and build traces are emitted to the file system.
  ([#749](#749))

## heroku/nodejs-npm-install

### Added

- Enabled libcnb `trace` feature, so that OpenTelemetry file exports with
  buildpack detect and build traces are emitted to the file system.
  ([#749](#749))

## heroku/nodejs-pnpm-install

### Added

- Enabled libcnb `trace` feature, so that OpenTelemetry file exports with
  buildpack detect and build traces are emitted to the file system.
  ([#749](#749))

## heroku/nodejs-yarn

### Added

- Enabled libcnb `trace` feature, so that OpenTelemetry file exports with
  buildpack detect and build traces are emitted to the file system.
  ([#749](#749))

Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants