Skip to content

Support ARM64 #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
runesoerensen wants to merge 37 commits into from
Closed

Support ARM64 #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
e1f9157
Move os and arch to separate fields
runesoerensen Mar 6, 2024
e8bdd79
Add GoFile#filename
runesoerensen Mar 6, 2024
dbd9042
Add Artifact#url
runesoerensen Mar 6, 2024
87929a4
Prefer go.dev/dl for artifact url
runesoerensen Mar 6, 2024
ae0c4e6
Update inventory.toml
runesoerensen Mar 6, 2024
4833c3f
Use Artifact#url
runesoerensen Mar 6, 2024
c2c00bd
Explicitly set os and arch values
runesoerensen Mar 6, 2024
7d0ebc8
Resolve artifacts matching current platform
runesoerensen Mar 6, 2024
66ba828
Try from GoFile for Artifact conversion
runesoerensen Mar 8, 2024
640156e
Map GoFile arch to Inventory#arch
runesoerensen Mar 8, 2024
de7c746
Handle unsupported Go file arch
runesoerensen Mar 9, 2024
e70dbd1
Inline variables
runesoerensen Mar 9, 2024
ad71034
Parse go file os value
runesoerensen Mar 9, 2024
121c01c
Handle arm64 GoFiles
runesoerensen Mar 9, 2024
a324c87
Prefer error enum over coercion
runesoerensen Mar 9, 2024
605432e
Wrap request errors in a new box
runesoerensen Mar 9, 2024
e5dcf1d
Explicitly map conversion error
runesoerensen Mar 12, 2024
39a7a9f
Refactor Artifact#arch as an enum
runesoerensen Mar 12, 2024
341988a
Test arch display format
runesoerensen Mar 12, 2024
0882756
Test arch parsing
runesoerensen Mar 12, 2024
fe76782
Test unsupported arch error
runesoerensen Mar 12, 2024
6e2be6f
Should parse artifact arch from own format
runesoerensen Mar 12, 2024
f0922bf
Match typed Arch when resolving
runesoerensen Mar 12, 2024
9f7ff3d
Prefer using Os enum for Artifact#Os
runesoerensen Mar 12, 2024
32792fe
Test os display format
runesoerensen Mar 12, 2024
c2be42a
Test os parsing
runesoerensen Mar 12, 2024
2f6ae19
Compare artifacts based on checksum
runesoerensen Mar 8, 2024
044b866
Add arm64 linux artifacts to inventory
runesoerensen Mar 8, 2024
4f46dba
Improve variable naming accuracy
runesoerensen Mar 9, 2024
e9dc886
Dedup logic
runesoerensen Mar 9, 2024
ecda2de
Prefer named variables
runesoerensen Mar 9, 2024
7ea023d
Remove whitespace in artifact os/arch pair
runesoerensen Mar 12, 2024
9e2c51b
Expand tuple in filter function
runesoerensen Mar 12, 2024
f04aeff
Test Display implementation for artifact
runesoerensen Mar 12, 2024
36712ee
Verify Hash impl for Artifact
runesoerensen Mar 13, 2024
51a976d
Implement default for Artifact tests
runesoerensen Mar 13, 2024
cbaf88a
Add arm64 CNB support
runesoerensen Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions buildpacks/go/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Implement Buildpack API 0.10. ([#231](https://github.com/heroku/buildpacks-go/pull/231))

### Added

- Added linux aarch64 artifacts for >= go1.8.5. ([#230](https://github.com/heroku/buildpacks-go/pull/230))

## [0.2.0] - 2024-03-06

### Added
Expand Down
4 changes: 4 additions & 0 deletions buildpacks/go/buildpack.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ clear-env = true
[[buildpack.licenses]]
type = "BSD-3-Clause"

[[targets]]
os = "linux"
arch = "arm64"

[[targets]]
os = "linux"
arch = "amd64"
Expand Down
Loading