Add inventory support for arm64 linux artifacts#230
Merged
runesoerensen merged 12 commits intomainfrom Mar 14, 2024
Merged
Conversation
runesoerensen
changed the title
runesoerensen
changed the title
runesoerensen
force-pushed
the
refactor-utility-functions
branch
from
065c546 to
3f83106
Compare
runesoerensen
changed the title
runesoerensen
added
enhancement
Closed
colincasey
requested changes
Mar 12, 2024
runesoerensen
force-pushed
the
refactor-artifact-architecture
branch
from
3005bc3 to
e5dcf1d
Compare
runesoerensen
force-pushed
the
refactor-utility-functions
branch
from
be656f8 to
30445f6
Compare
colincasey
reviewed
Mar 12, 2024
colincasey
reviewed
Mar 12, 2024
runesoerensen
force-pushed
the
refactor-utility-functions
branch
2 times, most recently
from
6be76a9 to
f04aeff
Compare
Format artifacts with OS and arch
Co-authored-by: Colin Casey <casey.colin@gmail.com>
Co-authored-by: Colin Casey <casey.colin@gmail.com>
runesoerensen
force-pushed
the
refactor-utility-functions
branch
from
51a976d to
31976eb
Compare
Merged
colincasey
reviewed
Mar 13, 2024
colincasey
reviewed
Mar 14, 2024
colincasey
approved these changes
Mar 14, 2024
This was referenced Apr 5, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #229, and updates the inventory utils to support artifacts for multiple architectures and operating systems.
Artifactnow implements theHashtrait.Artifact#hashis implemented to rely solely on thesha_checksumvalue. I think it's likely safe to assume the checksum values will be unique for each Artifact entry, but please share any concerns regarding that approach.inventory.tomlfile includes quite a few additions as well. 3f83106 addedaarch64artifacts for all Go versions >=go1.8.5.