Refactor .NET project file parsing#335
Merged
runesoerensen merged 38 commits intomainfrom Oct 30, 2025
Merged
Conversation
edmorley
approved these changes
Oct 30, 2025
Merged
heroku-linguist bot
added a commit
that referenced
this pull request
Nov 11, 2025
## heroku/dotnet ### Added - Support for .NET 10 file-based apps. ([#336](#336)) ### Changed - Refactored .NET project file parsing to allign with MSBuild behavior and project file semantics. ([#335](#335)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Nov 11, 2025
## heroku/dotnet ### Added - Support for .NET 10 file-based apps. ([#336](heroku/buildpacks-dotnet#336)) ### Changed - Refactored .NET project file parsing to allign with MSBuild behavior and project file semantics. ([#335](heroku/buildpacks-dotnet#335))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the .NET project file parsing logic to use
quick-xml's deserialization feature instead of manual XML tree traversal withroxmltree. This is similar to the approach used in the recently added SLNX parsing logic, and now better alligns with .NET project file semantics as well MSBuild behavior:roxmltreedependency in favor ofquick-xmldeserialization.ProjectXml,PropertyGroup,SdkElement) withserdederives to automatically parse project files.parse_metadatafunction that walked the XML tree with declarative property extraction from deserialized structs.<PropertyGroup>elements, particularly forAssemblyNamewhere blank/whitespace values trigger fallback to the filename.The goal is to make the code cleaner and more maintainable in preparation for some planned upcoming changes to the
project.rschanges.GUS-W-20073970