Removed lwip and updated to newest librs #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2024
CarlWachter
force-pushed
the
no_lwip
branch
2 times, most recently
from
fa34dfd to
3436cb6
Compare
mkroening
reviewed
May 29, 2024
mkroening
requested changes
May 31, 2024
Member
mkroening
left a comment
mkroening
left a comment
There was a problem hiding this comment.
The code looks fine. It would be great if we did not lose Fortran support if possible.
Contributor
Author
|
Added a few fixes to benchmarks and tests, which for various reasons, did not work before. Could potentially warrant a new PR, but since this PR is supposed to put everything into a working state I will just throw them in here. |
mkroening
approved these changes
Jun 3, 2024
mkroening
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hermit-os/kernel#656 can also be merged after this, since
hermit/mailbox.hwas removed.hermit-os/kernel#1165 also depends on this PR.
See also: hermit-os/newlib#1