feat: Merge hermit-image-reader into this crate
#61
Conversation
fogti
force-pushed
the
image-reader
branch
3 times, most recently
from
c95bd47 to
d26ee72
Compare
| [dependencies.byte-unit] | ||
| version = "5" | ||
| default-features = false | ||
| features = ["byte", "serde"] | ||
| optional = true | ||
|
|
||
| [dependencies.compression] | ||
| version = "0.1" | ||
| default-features = false | ||
| features = ["gzip"] | ||
| optional = true | ||
|
|
||
| [dependencies.goblin] | ||
| version = "0.10" | ||
| default-features = false | ||
| features = ["elf64"] | ||
| optional = true | ||
|
|
||
| [dependencies.num-traits] | ||
| version = "0.2" | ||
| default-features = false | ||
|
|
||
| [dependencies.serde] | ||
| version = "1" | ||
| default-features = false | ||
| features = ["alloc", "derive"] | ||
| optional = true | ||
|
|
||
| [dependencies.toml] | ||
| version = "0.9" | ||
| default-features = false | ||
| features = ["parse", "serde"] | ||
| optional = true | ||
|
|
||
| [dependencies.yoke] | ||
| version = "0.8" | ||
| default-features = false | ||
| features = ["derive"] | ||
| optional = true | ||
|
|
||
| [dev-dependencies.proptest] | ||
| version = "1.9" | ||
|
|
There was a problem hiding this comment.
Is there a specific reason you are using the explicit dependencies instead of the "one-liners"?
There was a problem hiding this comment.
It is a bit hard to read "one-liners" when they contain nested structures (features) and often wrap the line (or alternatively go out of field of vision when the window is small enough).
There was a problem hiding this comment.
I guess it is an implicit kind of code-style to use the one-liners in the hermit projects. For consistency reasons, I'd stick to it. A mixture seems like a bad choice from my perspective.
There was a problem hiding this comment.
Does the Hermit kernel Cargo.toml count? (because it does mix those)
There was a problem hiding this comment.
But only for the "very complex" smoltcp and the ones where we have platform specific dependencies.
There was a problem hiding this comment.
Do we have some policy ala "dependencies should be in the multi-line format when the line length exceeds N"?
There was a problem hiding this comment.
No. But I think here the one-liners are a better choice
There was a problem hiding this comment.
Is the current version okay (I transformed every entry with at most one feature into a one-liner)?
There was a problem hiding this comment.
Fine for me. Maybe @mkroening has some opinion on this.
|
For now, I fixed many of the complaints in the uhyve version of this PR, and will port them to this one later. edit: okay, ported. |
fogti
force-pushed
the
image-reader
branch
8 times, most recently
from
60353e9 to
1450be7
Compare
fogti
force-pushed
the
image-reader
branch
2 times, most recently
from
e2609aa to
ee728b4
Compare
|
I have now completely split this from #62, to make review + fixes easier. |
fogti
force-pushed
the
image-reader
branch
3 times, most recently
from
7d0e573 to
723759e
Compare
fogti
force-pushed
the
image-reader
branch
4 times, most recently
from
da5dd36 to
c55f6bb
Compare
fogti
force-pushed
the
image-reader
branch
4 times, most recently
from
b720109 to
f8c2e61
Compare
|
hermit-os/hermit-rs#856 should help with further necessary development (integration into kernel) |
Signed-off-by: Ellen Εμιλία Άννα Zscheile <[email protected]>
2 participants
No description provided.