Fix handling of deeply nested charts_dir#47
Merged
unguiculus merged 1 commit intohelm:masterfrom Oct 29, 2020
Merged
Conversation
LukeCarrier
force-pushed
the
nested-chart-dir
branch
from
f9ba776 to
c474c8a
Compare
Closed
unguiculus
requested changes
Oct 26, 2020
Member
unguiculus
left a comment
unguiculus
left a comment
There was a problem hiding this comment.
That's a pretty clever solution. Thanks.
Member
Fixes helm#46 Signed-off-by: Luke Carrier <luke@carrier.im>
LukeCarrier
force-pushed
the
nested-chart-dir
branch
from
c474c8a to
d14fa29
Compare
unguiculus
approved these changes
Oct 27, 2020
scottrigby
approved these changes
Oct 29, 2020
unguiculus
added a commit
to unguiculus/chart-releaser-action
that referenced
this pull request
Oct 30, 2020
This reverts commit ee2ad4e.
unguiculus
added a commit
to unguiculus/chart-releaser-action
that referenced
this pull request
Oct 30, 2020
This reverts commit ee2ad4e. Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
unguiculus
added a commit
to unguiculus/chart-releaser-action
that referenced
this pull request
Oct 30, 2020
This reverts commit ee2ad4e. Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
unguiculus
added a commit
to unguiculus/chart-releaser-action
that referenced
this pull request
Oct 30, 2020
This reverts commit ee2ad4e. Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
|
This fix seems to have broken things. when using the @master of this action now only the first chart in my REPO/charts/* folder is getting released.... |
the issue turns out to be absolute vs relative paths. i was passing in an absolute path to my charts dir, that worked with |
|
Using "." as chart dir is broken too :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46